Hotfix: Mode sanity check should be done before trying to open the lo…

…om! #26
aertslab · Oct 2, 2020 · 4f554a0 · 4f554a0
1 parent 64c3702
commit 4f554a0
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/R/loom.R b/R/loom.R
@@ -2584,6 +2584,9 @@ open_loom <- function(
   file.path,
   mode="r"
 ) {
+  if(mode != "r" & mode != 'r+') {
+    stop("'r' (read) and 'r+' (read/write) modes are only allowed.")
+  }
   loom <- tryCatch(
     {
       H5File$new(
@@ -2600,9 +2603,6 @@ open_loom <- function(
       stop(e)
     }
   )
-  if(mode != "r" & mode != 'r+') {
-    stop("'r' (read) and 'r+' (read/write) modes are only allowed.")
-  }
   if(is_loom_spec_version_3_or_greater(loom = loom)) {
     warning("Loom specification version 3 or greater detected!")
   } else {