Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement log-probability for StudentTRV #199

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

rlouf
Copy link
Member

@rlouf rlouf commented Nov 3, 2022

Follows the addition of StudentTRV in Aesara in aesara-devs/aesara#1211. Closes #185.

This is a draft, with no guarantee that the results are correct; the tests need to be expanded.

Thank you for opening a PR!

Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR. If your commit description starts with "Fix...", then you're probably making this mistake.
  • There are tests covering the changes introduced in the PR.

@rlouf rlouf added enhancement New feature or request op-probability Involves the implementation of log-probabilities for Aesara `Op`s labels Nov 3, 2022
@rlouf rlouf changed the title Implement log-probability for StudentTRV Implement log-probability for StudentTRV Nov 3, 2022
@rlouf rlouf force-pushed the student-logp branch 4 times, most recently from 798c648 to 0830ac1 Compare November 3, 2022 17:22
@brandonwillard brandonwillard force-pushed the student-logp branch 2 times, most recently from d141782 to 1614c85 Compare November 3, 2022 23:48
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 95.16% // Head: 95.18% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c4ffb39) compared to base (961496a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   95.16%   95.18%   +0.01%     
==========================================
  Files          12       12              
  Lines        1945     1952       +7     
  Branches      254      254              
==========================================
+ Hits         1851     1858       +7     
  Misses         52       52              
  Partials       42       42              
Impacted Files Coverage Δ
aeppl/logprob.py 98.07% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brandonwillard brandonwillard marked this pull request as ready for review November 4, 2022 04:30
@brandonwillard brandonwillard merged commit 54a5888 into aesara-devs:main Nov 4, 2022
@rlouf rlouf deleted the student-logp branch November 4, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request op-probability Involves the implementation of log-probabilities for Aesara `Op`s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement log-probability for StudentTRV
2 participants