Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly remove AePPL IR from conditional_logprob results #223

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

brandonwillard
Copy link
Member

@brandonwillard brandonwillard commented Jan 25, 2023

This PR adds a clean-up step to conditional_logprob that removes AePPL-specific IR. It also has a couple important updates for recent CI and Aesara updates.

Closes #222.

@brandonwillard brandonwillard self-assigned this Jan 25, 2023
@brandonwillard brandonwillard added bug Something isn't working graph rewriting Involves the implementation of rewrites to Aesara graphs labels Jan 25, 2023
@brandonwillard brandonwillard added the important This label is used to indicate priority over things not given this label label Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 96.12% // Head: 96.19% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (8a04864) compared to base (7890228).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   96.12%   96.19%   +0.06%     
==========================================
  Files          12       12              
  Lines        1987     1996       +9     
  Branches      241      239       -2     
==========================================
+ Hits         1910     1920      +10     
  Misses         39       39              
+ Partials       38       37       -1     
Impacted Files Coverage Δ
aeppl/abstract.py 98.64% <100.00%> (+0.01%) ⬆️
aeppl/joint_logprob.py 94.44% <100.00%> (ø)
aeppl/rewriting.py 95.91% <100.00%> (+0.31%) ⬆️
aeppl/transforms.py 96.93% <100.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brandonwillard brandonwillard merged commit fb6ffc5 into aesara-devs:main Jan 25, 2023
@brandonwillard brandonwillard deleted the remove-aeppl-ir branch January 25, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working graph rewriting Involves the implementation of rewrites to Aesara graphs important This label is used to indicate priority over things not given this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValuedVariable still present in the logdensity graph
1 participant