Small fixes after PR review

aesara/graph/callcache.py

@@ -1,6 +1,6 @@
 import logging
 import pickle
-from typing import Callable, Dict, NoReturn, Optional, Tuple
+from typing import Callable, Dict, Optional, Tuple
 
 
 _logger = logging.getLogger("aesara.graph.callcache")
@@ -17,7 +17,7 @@ def __init__(self, filename: Optional[str] = None):
         except OSError:
             self.cache: Dict = {}
 
-    def persist(self, filename: Optional[str] = None) -> NoReturn:
+    def persist(self, filename: Optional[str] = None) -> None:
         """
         Cache "filename" as a pickle file
         """
@@ -47,7 +47,7 @@ def call(self, fn: Callable, args: Tuple = (), key: Optional[Tuple] = None):
             _logger.debug("cache hit %i", len(self.cache))
         return self.cache[key]
 
-    def __del__(self) -> NoReturn:
+    def __del__(self) -> None:
         try:
             if self.filename:
                 self.persist()

aesara/tensor/basic.py

@@ -316,8 +316,8 @@ def get_scalar_constant_value(
 
     Parameters
     ----------
-    orig_v :
-
+    orig_v : int, float, np.ndarray, Constant or None
+        The variable `v` where to find the constant scalar(0-D).
     elemwise : bool
         If False, we won't try to go into elemwise. So this call is faster.
         But we still investigate in Second Elemwise (as this is a substitute