Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyPI workflow to also build a wheel #1048

Merged
merged 2 commits into from Jul 11, 2022

Conversation

keesterbrugge
Copy link
Contributor

Hello Y'all,

PR solves #1047. TLDR: pypi can't figure the dependencies of aesara if the wheel isn't uploaded.

During the github action that publishes to pypi make sure to not only build a sdist but also a wheel. This is similar to what happens when executing make pypi. Twine (inside pypa/gh-action-pypi-publish@master) will automatically upload the wheel first such that pypi can extract the dependencies better and the pypi json api doesn't return requires_dist = null

Thank you for this awesome tool!   🙇‍♂️

@brandonwillard brandonwillard added enhancement New feature or request CI Involves continuous integration labels Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1048 (9a0b19d) into main (c1fef51) will not change coverage.
The diff coverage is n/a.

❗ Current head 9a0b19d differs from pull request most recent head ca9c5b3. Consider uploading reports for the commit ca9c5b3 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1048   +/-   ##
=======================================
  Coverage   79.26%   79.26%           
=======================================
  Files         152      152           
  Lines       47874    47874           
  Branches    10908    10908           
=======================================
  Hits        37948    37948           
  Misses       7429     7429           
  Partials     2497     2497           

@brandonwillard brandonwillard merged commit b4912d9 into aesara-devs:main Jul 11, 2022
@brandonwillard brandonwillard changed the title Update pypi.yml to also build wheel Update PyPi workflow to also build a wheel Jul 11, 2022
@brandonwillard brandonwillard linked an issue Jul 11, 2022 that may be closed by this pull request
@brandonwillard brandonwillard changed the title Update PyPi workflow to also build a wheel Update PyPI workflow to also build a wheel Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Involves continuous integration enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPI JSON API returns "requires_dist":null
2 participants