Clean up SparseTensorType
#1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
force-pushed
the
misc-sparse-refactoring
branch
from
a9d9d7a
to
987db75
Compare
brandonwillard
force-pushed
the
misc-sparse-refactoring
branch
from
987db75
to
dc294fc
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
==========================================
+ Coverage 79.12% 79.13% +0.01%
==========================================
Files 173 173
Lines 48458 48465 +7
Branches 10961 10963 +2
==========================================
+ Hits 38341 38354 +13
+ Misses 7610 7608 -2
+ Partials 2507 2503 -4
|
|
Does this solve the inconsistencies observed in #881? |
ricardoV94
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the interface and error behavior of
SparseTensorType—mostly relative toTensorType. It also contains some docstring and comment refactoring in theaesara.sparsesub-package.