Fix bad initial values shape assumptions in save_mem_new_scan rewrite
#1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
added
bug
brandonwillard
force-pushed
the
fix-scan-save-mem-bcast-bug
branch
from
867ba88
to
cfe2af7
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1501 +/- ##
=======================================
Coverage 74.96% 74.96%
=======================================
Files 176 176
Lines 49502 49500 -2
Branches 11987 11986 -1
=======================================
+ Hits 37108 37110 +2
+ Misses 10092 10089 -3
+ Partials 2302 2301 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1499. The underlying issue was that
save_mem_new_scanalways assumed that the output storage array graphs, which take the format.set_subtensor(at.empty[:tap_spread], initial_tap_values), would have non-scalarinitial_tap_values; however, this isn't always the case.In general, the logic in
save_mem_new_scanis a bit convoluted and unclear about the assumptions it makes. These changes don't completely fix that, but they do provide some refactoring that improves the situation a little.