Fixed: Inv Numba implementation now correctly returns non-integral in… #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verses of integer inputs
Codecov Report
@@ Coverage Diff @@
## main #627 +/- ##
=======================================
Coverage 77.02% 77.02%
=======================================
Files 157 157
Lines 46911 46915 +4
Branches 10265 10265
=======================================
+ Hits 36132 36136 +4
Misses 8196 8196
Partials 2583 2583
|
brandonwillard
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix which replaces Numpy's reciprocal function for Numba implementation of
InvOps with a direct inverse signature.Fixes #624