Add missing Constant validation to OpFromGraph constructor
#704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
force-pushed
the
add-missing-opfromgraph-validation
branch
from
ec22286
to
1dfe3bf
Compare
Codecov Report
@@ Coverage Diff @@
## main #704 +/- ##
==========================================
+ Coverage 77.66% 77.67% +0.01%
==========================================
Files 152 152
Lines 46961 46964 +3
Branches 10891 10892 +1
==========================================
+ Hits 36470 36479 +9
+ Misses 7894 7891 -3
+ Partials 2597 2594 -3
|
brandonwillard
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing validation to
OpFromGraph, as well as some minor docstring and exception refactoring.