Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing issues in core modules #837

Conversation

brandonwillard
Copy link
Member

This PR fixes some typing issues in core Aesara modules and enables them for Mypy checking from here on.

@brandonwillard brandonwillard force-pushed the fix-some-graph-subpackage-typing branch 5 times, most recently from 08c7c85 to 7ebe2a2 Compare March 2, 2022 02:15
@brandonwillard brandonwillard added enhancement New feature or request refactor This issue involves refactoring labels Mar 2, 2022
@brandonwillard brandonwillard force-pushed the fix-some-graph-subpackage-typing branch 2 times, most recently from 95d6cf2 to 8c9fa1f Compare March 2, 2022 05:13
@brandonwillard brandonwillard force-pushed the fix-some-graph-subpackage-typing branch from 8c9fa1f to 2cf550c Compare March 2, 2022 05:24
@brandonwillard brandonwillard force-pushed the fix-some-graph-subpackage-typing branch from 310331e to ef00cc9 Compare March 2, 2022 17:26
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #837 (ef00cc9) into main (c27183c) will increase coverage by 0.04%.
The diff coverage is 76.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
+ Coverage   78.39%   78.43%   +0.04%     
==========================================
  Files         152      154       +2     
  Lines       47640    47708      +68     
  Branches    10841    10842       +1     
==========================================
+ Hits        37347    37421      +74     
+ Misses       7750     7747       -3     
+ Partials     2543     2540       -3     
Impacted Files Coverage Δ
aesara/compile/compiledir.py 0.00% <0.00%> (ø)
aesara/sandbox/fourier.py 0.00% <0.00%> (ø)
aesara/compile/nanguardmode.py 56.81% <50.00%> (+0.32%) ⬆️
aesara/link/c/op.py 61.41% <61.41%> (ø)
aesara/link/c/type.py 75.66% <75.66%> (ø)
aesara/graph/type.py 93.44% <90.90%> (+14.21%) ⬆️
aesara/graph/op.py 85.63% <91.30%> (+16.78%) ⬆️
aesara/compile/builders.py 74.64% <100.00%> (ø)
aesara/compile/debugmode.py 60.72% <100.00%> (+0.03%) ⬆️
aesara/compile/ops.py 83.68% <100.00%> (+0.11%) ⬆️
... and 39 more

@brandonwillard brandonwillard merged commit 15c55a3 into aesara-devs:main Mar 2, 2022
@brandonwillard brandonwillard deleted the fix-some-graph-subpackage-typing branch March 2, 2022 18:56
@brandonwillard brandonwillard added the typing Work related to type checking label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor This issue involves refactoring typing Work related to type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant