Fix the Numba implementation of CauchyRV
#843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
added
Numba
Codecov Report
@@ Coverage Diff @@
## main #843 +/- ##
==========================================
- Coverage 78.44% 78.44% -0.01%
==========================================
Files 154 154
Lines 47742 47749 +7
Branches 10848 10848
==========================================
+ Hits 37451 37456 +5
- Misses 7749 7750 +1
- Partials 2542 2543 +1
|
brandonwillard
force-pushed
the
fix-numba-cauchy-sampler
branch
from
fb06558
to
eb9e370
Compare
twiecki
previously approved these changes
Mar 4, 2022
`aesara.random.basic.negative_binomial` has also been added as an alias to `aesara.random.basic.nbinom`.
brandonwillard
force-pushed
the
fix-numba-cauchy-sampler
branch
from
f7afbdb
to
29da245
Compare
brandonwillard
force-pushed
the
fix-numba-cauchy-sampler
branch
from
29da245
to
d184c84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Numba implementation of
CauchyRV.The current tests for
RandomVariableimplementations that don't match the Aesara/NumPy RNG states need to be updated, because they're all set toxfailand—as a result—do not really verifying anything. I might fix that in this PR as well.