Remove unnecessary cloning from Scan rewrites
#903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #903 +/- ##
=======================================
Coverage 78.88% 78.89%
=======================================
Files 152 152
Lines 47662 47660 -2
Branches 10845 10842 -3
=======================================
+ Hits 37600 37602 +2
+ Misses 7558 7556 -2
+ Partials 2504 2502 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a lot of unnecessary graph cloning from the
Scanrewrites (mostly the push-out ones).