Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some input conversion issues in aesara.tensor #952

Merged

Conversation

brandonwillard
Copy link
Member

This PR fixes some bugs in aesara.tensor helper functions caused by a lack of as_tensor_variable conversions.

@brandonwillard brandonwillard self-assigned this May 9, 2022
@brandonwillard brandonwillard added bug Something isn't working refactor This issue involves refactoring NumPy compatibility labels May 9, 2022
@brandonwillard brandonwillard force-pushed the misc-interface-fixes branch 2 times, most recently from 8df2f3e to 6fa855b Compare May 9, 2022 02:09
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #952 (cfbe867) into main (6cca25e) will increase coverage by 0.00%.
The diff coverage is 89.47%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #952   +/-   ##
=======================================
  Coverage   78.99%   78.99%           
=======================================
  Files         152      152           
  Lines       47795    47809   +14     
  Branches    10888    10893    +5     
=======================================
+ Hits        37754    37768   +14     
  Misses       7541     7541           
  Partials     2500     2500           
Impacted Files Coverage Δ
aesara/compile/compiledir.py 0.00% <0.00%> (ø)
aesara/compile/function/types.py 79.91% <ø> (ø)
aesara/compile/profiling.py 75.13% <ø> (ø)
aesara/graph/opt.py 64.97% <0.00%> (ø)
aesara/link/c/basic.py 87.36% <ø> (ø)
aesara/link/c/cmodule.py 52.40% <ø> (ø)
aesara/link/jax/dispatch.py 80.86% <ø> (ø)
aesara/scan/basic.py 85.09% <ø> (ø)
aesara/sparse/opt.py 75.56% <ø> (-0.05%) ⬇️
aesara/tensor/nnet/basic.py 80.28% <0.00%> (ø)
... and 12 more

@brandonwillard brandonwillard merged commit 344ff6b into aesara-devs:main May 9, 2022
@brandonwillard brandonwillard deleted the misc-interface-fixes branch May 9, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working NumPy compatibility refactor This issue involves refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant