-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jax implementation of log1mexp
#994
Conversation
quick callout:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have a suggestion below for a more thorough check
I have seen that can sometimes happen when the pre-commit runs only on the modified files but goes away when it runs on all files. It's annoying though |
Codecov Report
@@ Coverage Diff @@
## main #994 +/- ##
=======================================
Coverage 79.23% 79.23%
=======================================
Files 152 152
Lines 47946 47951 +5
Branches 10916 10916
=======================================
+ Hits 37990 37995 +5
Misses 7448 7448
Partials 2508 2508
|
log1mexp
Looks good, can you squash the three commits into a single one? |
just squashed into 1 commit! |
Thanks @kylejcaron! |
Thanks for the help on this! |
This PR creates a Jjax implementation of the log1mexp op, to resolve issue #990
Thank you for opening a PR!
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.
If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.