Add speed setter and getter #2
Conversation
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Signed-off-by: Albert Esteve <aesteve@redhat.com>
aesteve-rh
force-pushed
the
add-speed-setter
branch
from
36c1e42
to
774e0a9
Compare
|
Thanks @barpavel ! |
| } | ||
| } | ||
| } | ||
|
|
||
| impl GetPropertyValue for EmulatorMessage { | ||
| fn get_value(&self) -> Result<VehiclePropertyValue> { | ||
| if self.value.len() != 1 { |
There was a problem hiding this comment.
If it can't be zero, maybe better change to >1.
There was a problem hiding this comment.
No, the only valid value is 1. With >1 it would allow empty vectors.
There was a problem hiding this comment.
No, you misunderstood me.
I meant the following:
!=1 means either 0 or more than 1 (2, 3, ...).
If zero values is possible, then returning ReceiveMessageTooManyValuesError is confusing.
If zero of values is not possible, then changing !=1 into >1 is the same, but more readable.
There was a problem hiding this comment.
But never mind, this is not that important, just explaining myself :)
There was a problem hiding this comment.
Ah! gotcha. Well, at least the size of the values vector is printed with the error :D
|
Ahhh, already merged, all good :) |
Add setter and getter for gear and speed (and display_speed).