nb::any is removed in nanobind v2.0.0 #106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to build aestream with libcaer and CUDA support, but ran into errors. It turns out that nanobind recently removed
nb::any
support innb::shape
, and that one should now use-1
instead. This PR fixes that here, and allows me to compile successfully withpip install git+https://github.com/Huizerd/aestream@dev/nb_any_bug --no-binary aestream -v
.Tested on Ubuntu 20.04, with
gcc-10
andg++-10
selected viaupdate-alternatives
as explained here. I have the latest libcaer master from here and CUDA toolkit 12.1 from here.I also got it built successfully in a conda environment:
Also, when I didn't have
g++-10
set as default and tried to build with CUDA support, I found that setting onlyCXX=g++-10
wasn't enough; you also have to set the host compiler for CUDA as follows:Maybe this could be added in the docs :)