null_model_und_sign not supported between instances of 'tuple' and 'int'

[vinferrer]

Hello,

I tried to use null_model_und_sign but it gave me this error:
/opt/anaconda3/lib/python3.6/site-packages/bct/algorithms/reference.py in null_model_und_sign(W, bin_swaps, wei_freq)
978 if np.size(np.where(Ap.flat)) < (n * (n - 1)):
979 W_r = randmio_und_signed(W, bin_swaps)
--> 980 Ap_r = W_r > 0
981 An_r = W_r < 0
982 else:

TypeError: '>' not supported between instances of 'tuple' and 'int'

I used an undirected signed matrix of 416x416. Could you help with this issue?

Cheers,
Vicente

[MuriloSchaefer]

Hey, I also had some issues with null_model_und_sign.

look at this PR: #74
After that change my code worked welll

[aestrivex]

Thanks. Your PR is now accepted. I'm not sure why I did not accept it when you submitted it. As a rule I accept these patches unless there is a conflict.

…

On Tue, Mar 24, 2020, 8:52 AM MuriloSchaefer ***@***.***> wrote: Hey, I also had some issues with null_model_und_sign. look at this PR: #74 <#74> After that change my code worked welll — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAET2HQQOMNNZ5YFWTKL6ALRJCUIHANCNFSM4IT3MDRQ> .

[frheault]

Hi @aestrivex,
Since it is related to the same function, I decided to post it here.

I am currently working on version 0.5.1 on python 3.7

At line 1008 of bct/algorithms/reference.py
wei_period = np.round(1 / wei_freq) # convert frequency to period
This has to be converted to int before line 1013
R = np.random.permutation(m)[:int(np.min((m, wei_period))]

Since the tag 0.5.1 isn't the one being install via pip install, I was wondering if it was still WIP?
Should I do a PR or wait it out (or fork) ?

[aestrivex]

There is nothing WIP. At some point I will try to find time to go through the entire package and make updates everywhere. Your PRs with fixes like this are always welcome.

…

On Tue, Apr 14, 2020 at 2:08 PM Francois Rheault ***@***.***> wrote: Hi @aestrivex <https://github.com/aestrivex>, Since it is related to the same function, I decided to post it here. I am currently working on version 0.5.1 on python 3.7 At line 1008 of bct/algorithms/reference.py wei_period = np.round(1 / wei_freq) # convert frequency to period This has to be converted to int before line 1013 R = np.random.permutation(m)[:int(np.min((m, wei_period))] Since the tag 0.5.1 isn't the one being install via pip install, I was wondering if it was still WIP? Should I do a PR or wait it out (or fork) ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAET2HQPBKJZJUZTFOLZODDRMSRANANCNFSM4IT3MDRQ> .

[aestrivex]

Fixed in #74