Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve build setup #8

Merged
merged 5 commits into from Aug 30, 2019
Merged

Improve build setup #8

merged 5 commits into from Aug 30, 2019

Conversation

tolbrino
Copy link
Contributor

This change consolidates the bash scripts into a single make file.

Also some automatic formatter changes were applied.

@tolbrino tolbrino added the enhancement New feature or request label Aug 27, 2019
@tolbrino tolbrino self-assigned this Aug 27, 2019
@AleksandarFilipov
Copy link
Contributor

AleksandarFilipov commented Aug 28, 2019 •
edited

@tolbrino this is great, but please lets merge this after the pending one. More specifically 15a0a39
furtheron, if you remove the formatter commit it would be easier to merge.

@tolbrino
Copy link
Contributor Author

@AleksandarFilipov I've rebased and updated this PR

AleksandarFilipov
AleksandarFilipov approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@AleksandarFilipov AleksandarFilipov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See that the hashes have been broken out, gets really explicit, which is great.

@tolbrino tolbrino merged commit 9e4b144 into master Aug 30, 2019
@tolbrino tolbrino deleted the tb-clean-build branch August 30, 2019 07:00
AleksandarFilipov pushed a commit that referenced this pull request Nov 5, 2019
@Aleksandarf
attempt keep circle ci happier #8
777687a
AleksandarFilipov pushed a commit that referenced this pull request Nov 5, 2019
@Aleksandarf
Revert "attempt keep circle ci happier #8"
f63234b 
This reverts commit 777687a.
AleksandarFilipov pushed a commit that referenced this pull request Jan 16, 2020
@tolbrino
Merge pull request #8 from aeternity/tb-clean-build
b2ec36b 
Improve build setup
AleksandarFilipov pushed a commit that referenced this pull request Jan 16, 2020
@Aleksandarf
attempt keep circle ci happier #8
9c18556
AleksandarFilipov pushed a commit that referenced this pull request Jan 16, 2020
@Aleksandarf
Revert "attempt keep circle ci happier #8"
4419b87 
This reverts commit 777687a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksandarFilipov AleksandarFilipov AleksandarFilipov approved these changes

Assignees

@tolbrino tolbrino

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tolbrino @AleksandarFilipov