Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing transaction details data for channels #1032

Closed
michele-franchi opened this issue Nov 21, 2022 · 2 comments
Closed

Add missing transaction details data for channels #1032

michele-franchi opened this issue Nov 21, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@michele-franchi
Copy link

Currently not all transactions data is returned from /v2/txs/:transactionId endpoint.

It would be useful to include the following data for these "Channel" transactions types to have a more detailed overview of these transaction types:

ChannelCreateTx:

  • Sent by

ChannelCloseMutualTx:

  • Responder
  • Initiator

ChannelCloseSoloTx:

  • Round
  • Initiator
  • Initiator amount
  • Responder
  • Responder amount

ChannelSlashTx:

  • Round

ChannelSettleTx:

  • Initiator
  • Initiator amount

ChannelSnapshotSoloTx:

  • Round
  • Initiator
  • Initiator amount
  • Responder
  • Responder amount

ChannelForceProgressTx:

  • Initiator
  • Initiator amount
  • Responder
  • Responder amount
@michele-franchi michele-franchi changed the title Add missing transaction details data Add missing transaction details data for channels Nov 21, 2022
@sborrazas sborrazas added the enhancement New feature or request label Nov 21, 2022
@sborrazas sborrazas self-assigned this Dec 1, 2022
@sborrazas
Copy link
Contributor

I've now added the /v2/channels/:id page for being able to retrieve most of this information. The round number updated on every snapshot and slash transaction is still missing. It will be added by @jyeshe in the future

@jyeshe
Copy link
Member

jyeshe commented Feb 10, 2023

@michele-franchi I am closing this considering it done as the issue involving channels is for another reason. The fields that you will find missing are for the reasons:

  • ChannelCreateTx: If there is no particular case missing the sender would be the initiator (after the creation, other transactions could be initiated by delegates). Actually the sender could be by someone paying_for the channel creation but it would be associated already in /txs. Fell free to open a specific issue if there is a specific requirement to make any additional relation with paying_for, ga_meta or other sender context.
  • ChannelCloseSoloTx, ChannelSnapshotSoloTx and ChannelForceProgressTx: The amounts are available only at microblock that might have multiple channel transactions in a way that could lead to imprecision if we put in these transactions. It was added a parameter to /channels/:channel though to allow querying the channel state including the amounts and reserve at a specific micro block.
  • ChannelSettleTx: please use initiator_amount_final

@jyeshe jyeshe closed this as completed Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants