feat: query channel reserve at a hash #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sborrazas
requested changes
Jan 4, 2023
lib/ae_mdw/channels.ex
Outdated
| end | ||
|
|
||
| defp get_block_index(state, param_block_hash) do | ||
| block_hash = Validate.id!(param_block_hash) |
There was a problem hiding this comment.
Perhaps we can send the decoded block_hash binary to avoid decoding it twice
There was a problem hiding this comment.
It was avoiding an additional parameter since the type is also needed and it's a few microseconds operation but did the optimization though.
| with {:ok, channel_pk} <- Validate.id(id, [:channel]), | ||
| {:ok, channel} <- Channels.fetch_channel(state, channel_pk) do | ||
| true <- valid_optional_block_hash?(block_hash), |
There was a problem hiding this comment.
This is the first decoding that we do, we can use its value by returning {:ok, block_hash}. In addition, if the parameter is not a valid block_hash the whole function returns false which is not handled by the FallbackController and it returns a 500 error
thepiwo
approved these changes
Jan 4, 2023
sborrazas
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1105
Refs #1032