fix: handle out_of_gas_error on aex141 cleanup #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for finding it @sborrazas |
sborrazas
reviewed
Aug 31, 2022
| @@ -25,7 +25,9 @@ defmodule AeMdwWeb.Helpers.AexnHelper do | |||
| @spec enc_id(pubkey()) :: String.t() | |||
| def enc_id(pk), do: :aeser_api_encoder.encode(:account_pubkey, pk) | |||
|
|
|||
| @spec sort_field_truncate(String.t()) :: String.t() | |||
| @spec sort_field_truncate(String.t() | :atom) :: String.t() | |||
There was a problem hiding this comment.
this should be atom() since :atom represents that literal atom
rest looks good 👍
thepiwo
approved these changes
Aug 31, 2022
jyeshe
force-pushed
the
fix-aex141-mainnet-cleanup
branch
from
c94e448
to
ce69211
Compare
|
rebased with new Dockerfile |
sborrazas
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid deleting aex141 contract indexed by metadata covering some mainnet cases.