chore: task for generating migrations #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaboiishere
approved these changes
Jun 6, 2024
sborrazas
changed the title
sborrazas
requested changes
Jun 6, 2024
lib/mix/tasks/gen.migration.ex
Outdated
|
|
||
| # The :change option may be used by other tasks but not the CLI | ||
| assigns = [ | ||
| # credo:disable-for-next-line |
There was a problem hiding this comment.
Let's avoid skipping credo errors. We're using them for a reason
There was a problem hiding this comment.
If we use safe_concat here (as it suggests) it fails, because the atom is not yet created. The warning is specifically against dynamically creating atoms - but this is exactly what is wanted here.
lib/mix/tasks/gen.migration.ex
Outdated
| defp pad(i), do: to_string(i) | ||
|
|
||
| embed_template(:migration, """ | ||
| defmodule <%= inspect @mod %> do |
There was a problem hiding this comment.
We can do AeMdw.Migration.<%= camelized_name %> here to avoid using macro functions
|
|
||
| embed_template(:migration, """ | ||
| defmodule <%= inspect @mod %> do | ||
| @spec run(State.t(), boolean()) :: {:ok, non_neg_integer()} |
There was a problem hiding this comment.
Can we add the State alias `alias AeMdw.Db.State?
sborrazas
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.