Add missed font-weights of IBM Plex Mono font #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
force-pushed
the
feature/add-missed-fonts
branch
from
c338f6a
to
a65086c
Compare
|
@etharner supposed to investigate this issue on Windows |
etharner
approved these changes
Jun 24, 2019
There was a problem hiding this comment.
Looks like it's only an issue with emulating of high DPI smartphones (e.g. iPhone 6/7/8) on low DPI screens like mine. Google Fonts provide different results for different user-agents (which is different when we emulating the device) for same link (https://css-tricks.com/dont-just-copy-the-font-face-out-of-google-fonts-urls/). It looks like it leads to glitched rendering in my case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.