This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
not getting generations which are already loaded #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
suggested changes
Nov 5, 2018
There was a problem hiding this comment.
This version of store was implemented in a way that every block was loaded once. I still don't understand why @sadiqevani has replaced it with the less efficient approach (block should be loaded even if it was loaded before).
The code in this PR is too complex, I propose to implement it as it was before.
src/store/modules/blocks/actions.js
Outdated
|
|
||
| if (!generations.length) { | ||
| return state.generations | ||
| let height = await dispatch('height') |
There was a problem hiding this comment.
Use const instead of let where it is possible.
ror-shubham
force-pushed
the
feature/reduce-requests
branch
from
c60d561
to
a843474
Compare
|
@davidyuk Please have a look at the latest commits. |
davidyuk
reviewed
Nov 21, 2018
src/store/modules/blocks/state.js
Outdated
| blocks: [], | ||
| generations: [] | ||
| generations: {}, | ||
| hash_to_height: {} |
There was a problem hiding this comment.
Usually, we are using camelCase.
This commit removes multiple instance creation of epoch client in all the action methods. This reduces multiple api requests and hence the loading time.
… for getGenerationByHash
ror-shubham
force-pushed
the
feature/reduce-requests
branch
from
7e96826
to
4b802af
Compare
|
@davidyuk I rebased this on top of other PRs and made the suggested changes. Please review again. |
davidyuk
approved these changes
Nov 23, 2018
This was referenced Nov 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.