fix(account): show network id in sign call output

aeternity · Apr 1, 2023 · 836f421 · 836f421
1 parent 27175fc
commit 836f421
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/actions/account.js b/src/actions/account.js
@@ -81,12 +81,13 @@ export async function sign(walletPath, tx, options) {
 
   const signedTx = await account.signTransaction(tx);
   const address = await account.address();
-  const networkId = account.getNetworkId();
+  const networkId = await account.getNetworkId();
   if (json) {
     print({ signedTx, address, networkId });
   } else {
     printUnderscored('Signing account address', address);
     printUnderscored('Network ID', networkId);
+    // TODO: remove unsigned tx because it is already accepted in arguments
     printUnderscored('Unsigned', tx);
     printUnderscored('Signed', signedTx);
   }

diff --git a/test/tx.js b/test/tx.js
@@ -103,14 +103,14 @@ This is an unsigned transaction. Use \`account sign\` and \`tx broadcast\` to su
     expect(responseJson.signedTx).to.satisfy((s) => s.startsWith(Encoding.Transaction));
     expect(responseJson).to.eql({
       address: TX_KEYS.publicKey,
-      networkId: {},
+      networkId: 'ae_devnet',
       signedTx: responseJson.signedTx,
     });
 
     const response = await executeProgram(accountProgram, args);
     expect(response).to.equal(`
 Signing account address _________________ ${TX_KEYS.publicKey}
-Network ID ______________________________ {}
+Network ID ______________________________ ae_devnet
 Unsigned ________________________________ ${tx}
 Signed __________________________________ ${responseJson.signedTx}
     `.trim());