Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update `new components submission guidelines` first draft #14

Merged
merged 3 commits into from Dec 8, 2017

Conversation

@dadaphl
Copy link
Contributor

commented Dec 7, 2017

Please discuss and expand/correct this guidelines.

@dadaphl dadaphl requested review from okwme, emil-apeunit, davidyuk and acdbaykal Dec 7, 2017
@dadaphl

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2017

okwme added 2 commits Dec 8, 2017
@okwme
okwme approved these changes Dec 8, 2017
Copy link
Contributor

left a comment

👍

@okwme okwme merged commit 60dddfe into master Dec 8, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@okwme okwme deleted the update-readme branch Dec 8, 2017
@acdbaykal

This comment has been minimized.

Copy link
Contributor

commented Dec 8, 2017

I'm not so sure about

Add all modifier classes (that represent type, state or similar things) of the component to the main wrapping element.

I think you should use modifier with each element effected by the state.So

.ae-progress-indicator._size_large { .progress-icon {...} .progress-label {...} }

would be more like

.ae-progress-indicator._size_large {} .progress-icon._size_large {} .progress-label._size_large{}
This reduces the specificity of your selectors and makes sub elements less dependent on their parent container. If you wanted pull out some elements into a new component and had used the method you suggested, you'd probably have to rewrite most of the css, because the parent element is not part of the new component. But if you let each child element handle it's state it becomes easier to reuse the css.

The second issue I have is not mentioning testing. We are shamefully guilty about that ourselves. But every component should be submitted with working tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.