Skip to content

Commit

Permalink
fix: GenericTx was not deserializing properly into go-swagger models.
Browse files Browse the repository at this point in the history
generated code was not parsing node responses that involved GenericTx. First fixed in 2cccbea but resurfaced after regenerating from new swagger.json
make go-swagger generated *Tx models return SpendTx, not SpendTxJSON
closes #54
  • Loading branch information
randomshinichi committed Apr 30, 2019
1 parent ffc4f8a commit b2b9cd5
Show file tree
Hide file tree
Showing 23 changed files with 45 additions and 43 deletions.
4 changes: 3 additions & 1 deletion api/edit.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
"""
The node's swagger.json cannot be used out of the box.
1. Manually replace all int64s with uint64s in swagger.json except for time (because go's time.Unix() accepts int64, not uint64)
2. Run this to add Fee/Balance/Amount BigInt in definitions and replace where necessary
2. Run this to add Fee/Balance/Amount/NameSalt BigInt in definitions and replace where necessary
3. generic_tx.go unmarshalGenericTx(): case "ChannelCloseMutualTxJSON": add "ChannelCloseMutualTx" etc for other Tx types
CAVEATS
/generations/height/{height} cannot be targeted, have to replace by hand
Expand Down
2 changes: 1 addition & 1 deletion generated/models/channel_close_mutual_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/channel_close_solo_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/channel_create_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/channel_deposit_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/channel_force_progress_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/channel_settle_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/channel_sla_s_h_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/channel_snapshot_solo_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/channel_withdrawal_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/contract_call_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/contract_create_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 21 additions & 21 deletions generated/models/generic_tx.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/name_claim_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/name_preclaim_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/name_revoke_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/name_transfer_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/name_update_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/oracle_extend_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/oracle_query_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/oracle_register_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/oracle_response_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated/models/spend_tx_json.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b2b9cd5

Please sign in to comment.