refactor!: remove ability to connect without sharing node if requested

BREAKING CHANGE: `shareNode` argument in accept callback of `onConnection` removed Just `deny` the connection if you don't want to share the node url.
aeternity · May 30, 2022 · 7dd4af5 · 7dd4af5
1 parent 791eb9a
commit 7dd4af5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/docs/guides/build-wallet.md b/docs/guides/build-wallet.md
@@ -146,9 +146,8 @@ async function init () {
       if (confirm(`Aepp ${aepp.info.name} with id ${aepp.id} wants to connect`)) {
         // Whitelist aepp domains for node connection
         const aepps = ['https://test', 'https://aepp.aeternity.com']
-        if (aepp.info.connectNode && aepps.includes(aepp.info.origin)) {
-          action.accept({ shareNode: true })
-        }
+        if (aepp.info.connectNode && aepps.includes(aepp.info.origin)) action.accept()
+        else action.deny()
         action.accept() // Accept wallet connection without sharing node URLs
       } else {
         action.deny()

diff --git a/src/utils/aepp-wallet-communication/rpc/wallet-rpc.js b/src/utils/aepp-wallet-communication/rpc/wallet-rpc.js
@@ -56,11 +56,11 @@ const METHOD_HANDLERS = {
     return callInstance(
       'onConnection',
       { name, version },
-      ({ shareNode } = {}) => {
-        client.updateInfo({ status: shareNode ? RPC_STATUS.NODE_BINDED : RPC_STATUS.CONNECTED })
+      () => {
+        client.updateInfo({ status: connectNode ? RPC_STATUS.NODE_BINDED : RPC_STATUS.CONNECTED })
         return {
           ...instance.getWalletInfo(),
-          ...shareNode && { node: instance.selectedNode }
+          ...connectNode && { node: instance.selectedNode }
         }
       },
       (error) => {

diff --git a/test/integration/rpc.js b/test/integration/rpc.js
@@ -454,7 +454,7 @@ describe('Aepp<->Wallet', function () {
         type: WALLET_TYPE.window,
         name: 'Wallet',
         onConnection (aepp, { accept }) {
-          accept({ shareNode: true })
+          accept()
         },
         onSubscription () {},
         onSign () {},