refactor(aepp)!: remove select option in connectToWallet

BREAKING CHANGE: Select option removed from connectToWallet If you are using `connectNode` then the current node would always be the same as wallet provides.
aeternity · Mar 28, 2023 · adf9c3e · adf9c3e
1 parent 20607c9
commit adf9c3e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/AeSdkAepp.ts b/src/AeSdkAepp.ts
@@ -92,8 +92,7 @@ export default class AeSdkAepp extends AeSdkBase {
    */
   async connectToWallet(
     connection: BrowserConnection,
-    { connectNode = false, name = 'wallet-node', select = false }:
-    { connectNode?: boolean; name?: string; select?: boolean } = {},
+    { connectNode = false, name = 'wallet-node' }: { connectNode?: boolean; name?: string } = {},
   ): Promise<WalletInfo> {
     if (this.rpcClient != null) throw new AlreadyConnectedError('You are already connected to wallet');
     let disconnectParams: any;
@@ -125,7 +124,7 @@ export default class AeSdkAepp extends AeSdkBase {
       .request(METHODS.connect, { name: this.name, version: RPC_VERSION, connectNode });
     if (connectNode) {
       if (node == null) throw new RpcConnectionError('Missing URLs of the Node');
-      this.addNode(name, new Node(node.url), select);
+      this.addNode(name, new Node(node.url), true);
     }
     this.rpcClient = client;
     return walletInfo;

diff --git a/test/integration/rpc.ts b/test/integration/rpc.ts
@@ -524,7 +524,7 @@ describe('Aepp<->Wallet', function aeppWallet() {
       wallet.addRpcClient(connectionFromWalletToAepp);
       await aepp.connectToWallet(
         connectionFromAeppToWallet,
-        { connectNode: true, name: 'wallet-node', select: true },
+        { connectNode: true, name: 'wallet-node' },
       );
     });