chore!: update rlp to 3.0.0

package.json

@@ -51,7 +51,7 @@
     "cross-fetch": "^3.1.5",
     "events": "^3.3.0",
     "process": "^0.11.10",
-    "rlp": "^2.2.7",
+    "rlp": "^3.0.0",
     "sha.js": "^2.4.11",
     "stream-browserify": "^3.0.0",
     "swagger-client": "^3.18.4",

src/tx/builder/helpers.js

@@ -199,7 +199,7 @@ export function writeId (hashId) {
  * @return {String} Encoided hash string with prefix
  */
 export function readId (buf) {
-  const tag = buf.readUIntBE(0, 1)
+  const tag = Buffer.from(buf).readUIntBE(0, 1)
   const prefix = ID_TAG_PREFIX[tag]
   if (!prefix) throw new PrefixNotFoundError(tag)
   return encode(buf.slice(1, buf.length), prefix)
@@ -224,7 +224,7 @@ export function writeInt (val) {
  * @return {String} Buffer Buffer from number(BigEndian)
  */
 export function readInt (buf = Buffer.from([])) {
-  return BigNumber(buf.toString('hex'), 16).toString(10)
+  return new BigNumber(Buffer.from(buf).toString('hex'), 16).toString(10)
 }
 
 /**

src/tx/tx-object.js

@@ -41,7 +41,7 @@ const buildTransaction = (type, params, options = {}) => {
 /**
  * Unpack transaction from RLP encoded binary or base64c string
  * @alias module:@aeternity/aepp-sdk/es/tx/tx-object
- * @param {Buffer|String} tx RLP encoded binary or base64c(rlpBinary) string
+ * @param {Uint8Array|String} tx RLP encoded binary or base64c(rlpBinary) string
  * @throws {Error} Arguments validation error's
  * @return {{
  *   encodedTx: String, binary: Array<Buffer>, rlpEncoded: Buffer, type: String, params: Object
@@ -53,10 +53,11 @@ const unpackTransaction = (tx) => {
     const { txType: type, tx: params, rlpEncoded, binary } = unpackTx(tx)
     return { encodedTx: tx, type, params, rlpEncoded, binary }
   }
-  if (Buffer.isBuffer(tx)) {
+  if (tx instanceof Uint8Array) {
     const { txType: type, tx: params, rlpEncoded, binary } = unpackTx(tx, true)
     return { encodedTx: encode(tx, 'tx'), type, params, rlpEncoded, binary }
   }
+  throw new InvalidTxError(`"tx" should be a string or Uint8Array, got ${tx} instead`)
 }
 
 /**

test/unit/tx-object.js

@@ -38,6 +38,10 @@ describe('TxObject', () => {
       expect(() => TxObject()).to.throw(InvalidTxError, 'Invalid TxObject arguments. Please provide one of { tx: "tx_asdasd23..." } or { type: "spendTx", params: {...} }')
     })
 
+    it('Invalid "tx"', () => {
+      expect(() => TxObject({ tx: {} })).to.throw(InvalidTxError, '"tx" should be a string or Uint8Array, got [object Object] instead')
+    })
+
     it('Invalid "params"', () => {
       expect(() => TxObject({ params: true, type: TX_TYPE.spend })).to.throw(TypeError, '"params" should be an object')
     })
@@ -67,23 +71,14 @@ describe('TxObject', () => {
       })
       signedTx = await MemoryAccount({ keypair: keyPair, networkId: 'ae_mainnet' }).signTransaction(txObject.encodedTx)
       txObject.encodedTx.should.be.a('string')
-      Buffer.isBuffer(txObject.rlpEncoded).should.be.equal(true)
+      expect(txObject.rlpEncoded).to.be.an.instanceOf(Uint8Array)
       txObject.binary.should.be.a('Array')
       txObject.params.should.be.a('object')
     })
 
     it('Unpack transaction from string/rlp', () => {
-      const txFromString = TxObject.fromString(txObject.encodedTx)
-      txFromString.rlpEncoded.equals(txObject.rlpEncoded).should.be.equal(true)
-      Buffer.from(txFromString.binary).equals(Buffer.from(txObject.binary)).should.be.equal(true)
-      txFromString.encodedTx.should.be.equal(txObject.encodedTx)
-      txFromString.params.should.be.deep.include(txObject.params)
-      const rtxFromRlpBinary = TxObject.fromRlp(txObject.rlpEncoded)
-      rtxFromRlpBinary.rlpEncoded.equals(txObject.rlpEncoded).should.be.equal(true)
-      Buffer.from(rtxFromRlpBinary.binary).equals(Buffer.from(txObject.binary))
-        .should.be.equal(true)
-      rtxFromRlpBinary.encodedTx.should.be.equal(txObject.encodedTx)
-      rtxFromRlpBinary.params.should.be.deep.include(txObject.params)
+      expect(TxObject.fromString(txObject.encodedTx)).to.eql(txObject)
+      expect(TxObject.fromRlp(txObject.rlpEncoded)).to.eql(txObject)
     })
 
     it('Unpack signed transaction', () => {