fix(node): show correct error message if body is missed

aeternity · Feb 13, 2024 · ed10482 · ed10482
1 parent 92f3ac1
commit ed10482
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 4 deletions.
diff --git a/src/channel/Base.ts b/src/channel/Base.ts
@@ -83,7 +83,7 @@ export default class Channel {
 
   _options!: ChannelOptions;
 
-  #debugId: number;
+  readonly #debugId: number;
 
   _channelId?: Encoded.Channel;
 

diff --git a/src/utils/autorest.ts b/src/utils/autorest.ts
@@ -82,10 +82,10 @@ export const genErrorFormatterPolicy = (
         try {
           body = JSON.parse(error.response.bodyAsText);
         } catch (e) {
-          throw error;
+          body = null;
         }
         error.message = `${new URL(error.request.url).pathname.slice(1)} error`;
-        const message = getMessage(body);
+        const message = body == null ? ` ${error.response.status} status code` : getMessage(body);
         if (message !== '') error.message += `:${message}`;
         throw error;
       }

diff --git a/test/integration/node.ts b/test/integration/node.ts
@@ -1,7 +1,9 @@
 import { describe, it, before } from 'mocha';
 import { expect } from 'chai';
 import { createSandbox } from 'sinon';
-import { PipelineRequest, PipelineResponse, SendRequest } from '@azure/core-rest-pipeline';
+import {
+  PipelineRequest, PipelineResponse, RestError, SendRequest,
+} from '@azure/core-rest-pipeline';
 import { url } from '.';
 import {
   AeSdkBase, Node, NodeNotFoundError, ConsensusProtocolVersion,
@@ -30,6 +32,24 @@ describe('Node client', () => {
       .to.be.rejectedWith('v3/transactions/th_test error: Invalid hash');
   });
 
+  it('throws clear exceptions when body is empty', async () => {
+    node.pipeline.addPolicy({
+      name: 'remove-response-body',
+      async sendRequest(request, next) {
+        try {
+          return await next(request);
+        } catch (error) {
+          if (!(error instanceof RestError) || error.response == null) throw error;
+          error.response.bodyAsText = '';
+          throw error;
+        }
+      },
+    });
+    await expect(node.getTransactionByHash('th_test'))
+      .to.be.rejectedWith('v3/transactions/th_test error: 400 status code');
+    node.pipeline.removePolicy({ name: 'remove-response-body' });
+  });
+
   it('retries requests if failed', async () => ([
     ['ak_test', 1],
     ['ak_2CxRaRcMUGn9s5UwN36UhdrtZVFUbgG1BSX5tUAyQbCNneUwti', 4],