Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/epoch 1.0.0 compatability #155

Merged
merged 5 commits into from
Nov 28, 2018

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Nov 28, 2018

No description provided.

Copy link
Contributor

@ricricucit ricricucit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nduchak now we have both bignumber.js...as dependency of JSONbig and BN.js for parseBigNumber and es/utils/bytes.js ...should we maybe only use bignumber.js

@nduchak nduchak force-pushed the features/epoch-1.0.0-compatability branch from 8697792 to 107fb42 Compare November 28, 2018 11:56
Copy link
Contributor

@ricricucit ricricucit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99% Approved :)

It would be great if we could get rid of BN.js in favor of bignumber.js in the future, since it's only used in es/utils/bytes.js, but adds about ~30Kb to the bundle.

I'll open an issue for this.

@ricricucit ricricucit mentioned this pull request Nov 28, 2018
@ricricucit ricricucit merged commit 7ce848f into develop Nov 28, 2018
@ricricucit ricricucit deleted the features/epoch-1.0.0-compatability branch November 30, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants