Fix BrowserRuntime in Firefox and pre-release fixes #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
commented
Jan 13, 2023
| onDisconnect, | ||
| ]; | ||
| this.port.onMessage.addListener(this.#listeners[0]); | ||
| this.port.onDisconnect.addListener(this.#listeners[1]); |
There was a problem hiding this comment.
This needs to be refactored, this code actually binds listeners, not connecting no anything
subhod-i
approved these changes
Jan 13, 2023
davidyuk
force-pushed
the
feature/fix-examples
branch
from
e5b9aaa
to
47243a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1734
The bug was introduced in 19cb42f#diff-36d07e359d2d2e15c6138f9cb478e39dc89c891e0bab325ba8508f32e1478063L90
Related fix in webextension-polyfill types Lusito/webextension-polyfill-ts#88
This PR is supported by the Æternity Crypto Foundation