Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aepp): don't call onDetected with empty wallet array #1801

Merged
merged 1 commit into from
May 9, 2023

Conversation

davidyuk
Copy link
Member

This happened for historical reasons, before the wallets object was the same for multiple calls of walletDetector.

This PR is supported by the Æternity Crypto Foundation

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (26014b7) 82.50% compared to head (80d97fa) 82.53%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1801      +/-   ##
===========================================
+ Coverage    82.50%   82.53%   +0.02%     
===========================================
  Files           90       90              
  Lines         3104     3103       -1     
  Branches       618      617       -1     
===========================================
  Hits          2561     2561              
+ Misses         251      250       -1     
  Partials       292      292              
Impacted Files Coverage Δ
src/aepp-wallet-communication/wallet-detector.ts 26.31% <ø> (+1.31%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidyuk davidyuk merged commit 8046aef into develop May 9, 2023
6 checks passed
@davidyuk davidyuk deleted the feature/on-detected-fix branch May 9, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant