Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide types in exports field of package.json #1837

Merged
merged 2 commits into from Jun 5, 2023
Merged

Conversation

davidyuk
Copy link
Member

Fixes compatibility with @vue/tsconfig

https://github.com/vuejs/tsconfig#migrating-from-typescript--50
https://nodejs.org/api/packages.html#community-conditions-definitions

This PR is supported by the Æternity Crypto Foundation

@davidyuk davidyuk requested a review from thepiwo May 30, 2023 13:09
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0dcb239) 82.55% compared to head (dbd19e7) 82.55%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1837   +/-   ##
========================================
  Coverage    82.55%   82.55%           
========================================
  Files           90       90           
  Lines         3118     3118           
  Branches       616      616           
========================================
  Hits          2574     2574           
  Misses         252      252           
  Partials       292      292           
Impacted Files Coverage Δ
src/Node.ts 91.66% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@thepiwo thepiwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidyuk davidyuk merged commit fe2e23e into develop Jun 5, 2023
6 checks passed
@davidyuk davidyuk deleted the feature/fix-types branch June 5, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants