Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contract): use fallback account if onAccount not provided #1851

Merged
merged 1 commit into from Jul 4, 2023

Conversation

davidyuk
Copy link
Member

closes #1844

This PR is supported by the Æternity Crypto Foundation

@davidyuk davidyuk added this to the v13.1.0 milestone Jun 28, 2023
@davidyuk davidyuk force-pushed the feature/fix-fallback-account branch from 1891535 to 9033cd7 Compare June 28, 2023 08:03
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (f837e90) 82.44% compared to head (9033cd7) 82.47%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1851      +/-   ##
===========================================
+ Coverage    82.44%   82.47%   +0.03%     
===========================================
  Files           93       93              
  Lines         3252     3252              
  Branches       648      648              
===========================================
+ Hits          2681     2682       +1     
  Misses         265      265              
+ Partials       306      305       -1     
Impacted Files Coverage Δ
src/contract/Contract.ts 75.14% <ø> (+0.56%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidyuk davidyuk merged commit 2e5e20e into develop Jul 4, 2023
5 checks passed
@davidyuk davidyuk deleted the feature/fix-fallback-account branch July 4, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InternalError didn't caught properly in Contract::$call
1 participant