Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aepp-wallet connection fixes #1865

Merged
merged 5 commits into from Jul 27, 2023
Merged

Aepp-wallet connection fixes #1865

merged 5 commits into from Jul 27, 2023

Conversation

davidyuk
Copy link
Member

This PR is supported by the Æternity Crypto Foundation

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (629d386) 82.32% compared to head (1d84843) 82.35%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1865      +/-   ##
===========================================
+ Coverage    82.32%   82.35%   +0.02%     
===========================================
  Files           94       94              
  Lines         3310     3315       +5     
  Branches       656      657       +1     
===========================================
+ Hits          2725     2730       +5     
  Misses         275      275              
  Partials       310      310              
Impacted Files Coverage Δ
src/AeSdkWallet.ts 82.14% <100.00%> (+0.83%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@CedrikNikita CedrikNikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look reasonable, _getAccountsForClient - nice.

@davidyuk davidyuk merged commit 0c97015 into develop Jul 27, 2023
5 checks passed
@davidyuk davidyuk deleted the feature/rpc-fixes branch July 27, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants