Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): uncatchable exception if request failed in queue #1892

Merged
merged 1 commit into from Sep 3, 2023

Conversation

davidyuk
Copy link
Member

I was making a lot of transactions one by one and because of the occasionally wrong nonce, some tx was rejected. The whole process was crushing since these exceptions weren't possible to handle.

This PR is supported by the Æternity Crypto Foundation

@davidyuk davidyuk added the bug Something isn't working label Aug 27, 2023
@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% ⚠️

Comparison is base (eeba565) 81.40% compared to head (dec62a4) 81.37%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1892      +/-   ##
===========================================
- Coverage    81.40%   81.37%   -0.03%     
===========================================
  Files           94       94              
  Lines         3361     3361              
  Branches       671      671              
===========================================
- Hits          2736     2735       -1     
- Misses         300      303       +3     
+ Partials       325      323       -2     
Files Changed Coverage Δ
src/tx/builder/constants.ts 100.00% <ø> (ø)
src/tx/builder/field-types/ct-version.ts 70.00% <ø> (ø)
src/utils/autorest.ts 90.66% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidyuk davidyuk merged commit 3ad19b1 into develop Sep 3, 2023
4 of 5 checks passed
@davidyuk davidyuk deleted the feature/fix-node-unhandled-error branch September 3, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant