Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url input and "show aepp" button to wallet-iframe example #1899

Merged
merged 3 commits into from Sep 19, 2023

Conversation

davidyuk
Copy link
Member

closes #1883
closes #1886

This PR is supported by the Æternity Crypto Foundation

@davidyuk davidyuk added this to the v13.2.2 milestone Sep 16, 2023
@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.09% ⚠️

Comparison is base (dec62a4) 81.37% compared to head (eb475c8) 81.28%.
Report is 14 commits behind head on develop.

❗ Current head eb475c8 differs from pull request most recent head f6b5bcd. Consider uploading reports for the commit f6b5bcd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1899      +/-   ##
===========================================
- Coverage    81.37%   81.28%   -0.09%     
===========================================
  Files           94       94              
  Lines         3361     3361              
  Branches       671      671              
===========================================
- Hits          2735     2732       -3     
- Misses         303      305       +2     
- Partials       323      324       +1     
Files Changed Coverage Δ
src/tx/builder/field-types/fee.ts 95.55% <0.00%> (ø)
src/tx/builder/field-types/gas-price.ts 77.77% <0.00%> (ø)
src/utils/crypto.ts 95.74% <ø> (ø)
src/contract/Contract.ts 75.28% <100.00%> (ø)
src/utils/autorest.ts 90.66% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidyuk davidyuk force-pushed the feature/url-input-wallet-iframe branch from eb475c8 to f6b5bcd Compare September 16, 2023 14:49
@davidyuk davidyuk merged commit 6dcdbf5 into develop Sep 19, 2023
2 of 3 checks passed
@davidyuk davidyuk deleted the feature/url-input-wallet-iframe branch September 19, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet iframe example is almost unusable on ios Allow to run an arbitrary aepp in wallet-iframe example
1 participant