Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aepp,wallet): connect to web-extension if opened over file:/// #1900

Merged
merged 1 commit into from Sep 19, 2023

Conversation

davidyuk
Copy link
Member

closes #1872

This PR is supported by the Æternity Crypto Foundation

@davidyuk davidyuk added this to the v13.2.2 milestone Sep 16, 2023
@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.05% ⚠️

Comparison is base (dec62a4) 81.37% compared to head (da6a025) 81.33%.
Report is 14 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1900      +/-   ##
===========================================
- Coverage    81.37%   81.33%   -0.05%     
===========================================
  Files           94       94              
  Lines         3361     3359       -2     
  Branches       671      670       -1     
===========================================
- Hits          2735     2732       -3     
  Misses         303      303              
- Partials       323      324       +1     
Files Changed Coverage Δ
src/aepp-wallet-communication/wallet-detector.ts 29.41% <0.00%> (+3.09%) ⬆️
src/tx/builder/field-types/fee.ts 95.55% <0.00%> (ø)
src/tx/builder/field-types/gas-price.ts 77.77% <0.00%> (ø)
src/utils/crypto.ts 95.74% <ø> (ø)
src/contract/Contract.ts 75.28% <100.00%> (ø)
src/utils/autorest.ts 90.66% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidyuk davidyuk merged commit 9589384 into develop Sep 19, 2023
3 of 5 checks passed
@davidyuk davidyuk deleted the feature/fix-file-schema branch September 19, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aepp-wallet connection is not working if aepp running over file:// protocol
1 participant