-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HD wallet functionality #41
Conversation
|
From a non-crypto point of view:
Only things I think would be nice to have:
|
@e-user, @muxe and me had a chat about this size problem. We came up with the understanding that the mnemonic part should not be part of the I have created an issue (#42) for that for further discussion. Lets put this PR on hold until we've reached consensus. Please discuss all separation related matters in issue #42 . |
It is performed in the constructor of Mnemonic, I don't think that we should make that validation more strict.
We have a
The problem is in |
I have found more popular |
is that more or less than before? I cant read any opinion from your last comment. Do you consider that a lot or little? |
bip39 is not performing it by default.
|
Using |
Superseded by https://github.com/aeternity/hd-wallet-js/. Thanks @davidyuk ! |
hs-key
functions are based on ed25519-hd-key package, both implementations correspond to SLIP-0010 specification.HMAC-SHA512 is calculating by
tweetnacl-auth
package, it has the same owner astweetnacl
, and it using SHA512 fromtweetnacl
.Accounts derivation path is taken from BIP-0044, except that in all path segments used hardened derivation because SLIP-0010 it not supports public derivation.
457
is a number generated by random.org and used as Aeternity coin type, probably it should be registered in SLIP-0044.https://www.pivotaltracker.com/story/show/157591833