Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(AE): Remove all deprecated stuff #697

Merged
merged 14 commits into from Dec 17, 2019
Merged

refactor(AE): Remove all deprecated stuff #697

merged 14 commits into from Dec 17, 2019

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Oct 4, 2019 •
edited

BREAKING CHANGES

  • Remove deprecated url, internalUrl params
  • Remove deprecated setKeypair for Account stamps

@nduchak nduchak added the enhancement New feature or request label Oct 4, 2019
@nduchak nduchak added this to the v5.0.0 milestone Oct 4, 2019
@nduchak nduchak self-assigned this Oct 4, 2019
@nduchak nduchak force-pushed the feat/remove-deprecated-stuff branch from 1693c55 to 2db66da Compare October 16, 2019 11:05
@noandrea noandrea removed this from the v6.0.0 milestone Nov 5, 2019
@noandrea noandrea mentioned this pull request Nov 5, 2019
Closed
@nduchak nduchak added this to the 7.0.0 milestone Nov 11, 2019
@noandrea noandrea modified the milestones: 7.0.0, 8.0.0 Nov 19, 2019
nduchak and others added 3 commits December 16, 2019 17:48
@nduchak
Merge branch 'develop' into feat/remove-deprecated-stuff
3cbdadb 
# Conflicts:
#	docs/examples/node/aecontract.md
#	es/contract/aci/index.js
#	test/integration/index.js
#	test/integration/transaction.js
@nduchak
refactor(Test): Fix merge conflict
f72a553
@nduchak
Merge branch 'develop' into feat/remove-deprecated-stuff
2ed4289
@codecov
Copy link

codecov bot commented Dec 16, 2019 •
edited

Codecov Report

Merging #697 into develop will decrease coverage by 6.7%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #697      +/-   ##
==========================================
- Coverage    88.51%   81.8%   -6.71%     
==========================================
  Files           45      55      +10     
  Lines         2411    2792     +381     
==========================================
+ Hits          2134    2284     +150     
- Misses         277     508     +231
Impacted Files Coverage Δ
es/account/memory.js 100% <ø> (+10.34%) ⬆️
es/utils/keystore.js 100% <ø> (ø) ⬆️
es/tx/tx.js 100% <ø> (ø) ⬆️
es/contract/ga/helpers.js 100% <ø> (ø) ⬆️
es/accounts.js 100% <100%> (+7.4%) ⬆️
es/contract/aci/index.js 100% <100%> (ø) ⬆️
es/tx/builder/schema.js 96.8% <100%> (+0.69%) ⬆️
es/ae/contract.js 96.42% <100%> (+0.06%) ⬆️
es/ae/oracle.js 98.03% <100%> (+0.03%) ⬆️
es/node-pool/index.js 100% <100%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29a162...88c820b. Read the comment docs.

@nduchak nduchak merged commit ef895ee into develop Dec 17, 2019
@nduchak nduchak mentioned this pull request Dec 18, 2019
Merged
@nduchak nduchak deleted the feat/remove-deprecated-stuff branch January 2, 2020 16:25
@davidyuk davidyuk removed this from the 8.0.0 milestone Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noandrea noandrea noandrea approved these changes

@mpowaga mpowaga Awaiting requested review from mpowaga

Assignees

@nduchak nduchak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nduchak @noandrea @davidyuk