Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with shape command #154

Closed
thepiwo opened this issue May 13, 2019 · 0 comments
Closed

Issues with shape command #154

thepiwo opened this issue May 13, 2019 · 0 comments

Comments

@thepiwo
Copy link
Collaborator

thepiwo commented May 13, 2019

  • sample contract style could be better, e.g. Map.lookup_default instead of switching, removing unused return values (create_nested_map_if_not_exists), _variable syntax instead of 'variable also not needed in all cases, get_todo should not created a empty todo, why have a get_caller function
  • the sample vue project advertises putting a private key in the frontend, I don't find this a suitable example, to help people build on aeternity we should advertise using the Aepp() injection approach, e.g. by including the sample identity provider in the example.
  • in the sample I find returnType !== '()' missleading, I don't think an abstraction for calling should be needed, why does onCallStatic use manual decode-type instead of relying on the aci and contractInstance? Also onCallStatic doesn't to a static call if I see correct, anyways why the on naming semantic?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants