Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed docs for *-bundle images #4304

Open
davidyuk opened this issue Mar 15, 2024 · 1 comment
Open

Missed docs for *-bundle images #4304

davidyuk opened this issue Mar 15, 2024 · 1 comment
Labels
need/triage New issues which need to be categorized

Comments

@davidyuk
Copy link
Member

Initially, I was writing this about not working devmode server in master-bundle, but seems it was fixed while I was writing this, the latest master-bundle works fine. Other issues I have:

Devmove plugin is included into *-bundle images since #3725. But I can't find any documentation regarding these images.

Another confusing part is that 3313 port is not mentioned in Dockerfile's EXPOSE section https://hub.docker.com/layers/aeternity/aeternity/master-bundle/images/sha256-d8a1704fc159c2b1aaa388b36e59dd7d1fee9f2810ce7a916be2f2e1bb490165?context=explore
I find out that it is not required, but still

@davidyuk davidyuk added the need/triage New issues which need to be categorized label Mar 15, 2024
@dincho
Copy link
Member

dincho commented Mar 15, 2024

We use single Dockerfile for now so we can't have an EXPOSE of the port. Documentation can be added indeed in the docker section of the docs.

@davidyuk davidyuk changed the title Missed docs for *-bundle images, 3313 port not mentioned in EXPOSE Missed docs for *-bundle images Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage New issues which need to be categorized
Projects
None yet
Development

No branches or pull requests

2 participants