jsonrpc: always reply to requests that have an 'id' #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucafavatella
previously approved these changes
Jun 7, 2019
lucafavatella
approved these changes
Jun 7, 2019
velzevur
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PT #166537135
In JSON-RPC, the client indicates that a request is synchronous by including an
"id"(some locally unique number). In this case, even if the method callback returnsno_reply, the handler should reply something, or the client is likely to block 'forever'. We choose to reply"ok".To test this change, the signing reply operation in
aehttp_integration_SUITEwas changed into a synchronous call. This made tests time out and fail before this fix was applied.