Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename aetx:min_gas into aetx:fee_gas #2938

Merged
merged 1 commit into from Oct 24, 2019
Merged

Conversation

hanssv
Copy link
Member

@hanssv hanssv commented Oct 24, 2019

Concludes Fixes #2937

tolbrino
tolbrino previously approved these changes Oct 24, 2019
Copy link
Contributor

@tolbrino tolbrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be really nice if you could add the explanation from the ticket as the function doc.

sennui
sennui previously approved these changes Oct 24, 2019
@hanssv hanssv dismissed stale reviews from sennui and tolbrino via 0087659 October 24, 2019 09:56
@hanssv hanssv force-pushed the GH-2937-rename_aetx_min_gas branch from 0cd6582 to 0087659 Compare October 24, 2019 09:56
@hanssv hanssv merged commit 3d5754e into master Oct 24, 2019
@hanssv hanssv deleted the GH-2937-rename_aetx_min_gas branch October 24, 2019 13:14
myotp added a commit that referenced this pull request Apr 28, 2021
…n branch (#2938)

Upgrade chain simulator (#3358)

* First edits to the chain sim. Added staking contract.

* Txs are passing

* Fixed some SC tests, HTTP is failing

* checkpoint

* typo

* Fix event type

* Fix events

* Fix the upgrade

* Chain sim is finally fully operational

* Fix some mismatches

* Cleanup

* Fix header hash, push aesophia, minor sanity

* Minor fix

Co-authored-by: Grzegorz Uriasz <gorbak25@gmail.com>
myotp added a commit that referenced this pull request Apr 28, 2021
…gration branch (#2938)

Hyperchains staking contract (#3381)

* Added staking contract and tests.

WIP STEP

Adding tests, extending chain sim features

More unit tests

checkpoint

Tests finally working

Added few tests, upgraded staking contract

* Get rid of unnecessary logging

* Minor fix

Minor fix

* Fixed logging, excluded staking contract tests outside iris

* Minor fix

* Fix logger in chain sim

* Optimize logging

* Explain dry run usage

* Add missing newlines after dots ~style~
myotp added a commit that referenced this pull request Apr 30, 2021
Upgrade chain simulator (#3358)

* First edits to the chain sim. Added staking contract.

* Txs are passing

* Fixed some SC tests, HTTP is failing

* checkpoint

* typo

* Fix event type

* Fix events

* Fix the upgrade

* Chain sim is finally fully operational

* Fix some mismatches

* Cleanup

* Fix header hash, push aesophia, minor sanity

* Minor fix

Co-authored-by: Grzegorz Uriasz <gorbak25@gmail.com>
myotp added a commit that referenced this pull request Apr 30, 2021
Hyperchains staking contract (#3381)

* Added staking contract and tests.

WIP STEP

Adding tests, extending chain sim features

More unit tests

checkpoint

Tests finally working

Added few tests, upgraded staking contract

* Get rid of unnecessary logging

* Minor fix

Minor fix

* Fixed logging, excluded staking contract tests outside iris

* Minor fix

* Fix logger in chain sim

* Optimize logging

* Explain dry run usage

* Add missing newlines after dots ~style~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename aetx:min_gas into aetx:fee_gas
3 participants