New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename aetx:min_gas into aetx:fee_gas #2938
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolbrino
previously approved these changes
Oct 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be really nice if you could add the explanation from the ticket as the function doc.
sennui
previously approved these changes
Oct 24, 2019
hanssv
force-pushed
the
GH-2937-rename_aetx_min_gas
branch
from
October 24, 2019 09:56
0cd6582
to
0087659
Compare
tolbrino
approved these changes
Oct 24, 2019
sennui
approved these changes
Oct 24, 2019
myotp
added a commit
that referenced
this pull request
Apr 28, 2021
…n branch (#2938) Upgrade chain simulator (#3358) * First edits to the chain sim. Added staking contract. * Txs are passing * Fixed some SC tests, HTTP is failing * checkpoint * typo * Fix event type * Fix events * Fix the upgrade * Chain sim is finally fully operational * Fix some mismatches * Cleanup * Fix header hash, push aesophia, minor sanity * Minor fix Co-authored-by: Grzegorz Uriasz <gorbak25@gmail.com>
myotp
added a commit
that referenced
this pull request
Apr 28, 2021
…gration branch (#2938) Hyperchains staking contract (#3381) * Added staking contract and tests. WIP STEP Adding tests, extending chain sim features More unit tests checkpoint Tests finally working Added few tests, upgraded staking contract * Get rid of unnecessary logging * Minor fix Minor fix * Fixed logging, excluded staking contract tests outside iris * Minor fix * Fix logger in chain sim * Optimize logging * Explain dry run usage * Add missing newlines after dots ~style~
myotp
added a commit
that referenced
this pull request
Apr 30, 2021
Upgrade chain simulator (#3358) * First edits to the chain sim. Added staking contract. * Txs are passing * Fixed some SC tests, HTTP is failing * checkpoint * typo * Fix event type * Fix events * Fix the upgrade * Chain sim is finally fully operational * Fix some mismatches * Cleanup * Fix header hash, push aesophia, minor sanity * Minor fix Co-authored-by: Grzegorz Uriasz <gorbak25@gmail.com>
myotp
added a commit
that referenced
this pull request
Apr 30, 2021
Hyperchains staking contract (#3381) * Added staking contract and tests. WIP STEP Adding tests, extending chain sim features More unit tests checkpoint Tests finally working Added few tests, upgraded staking contract * Get rid of unnecessary logging * Minor fix Minor fix * Fixed logging, excluded staking contract tests outside iris * Minor fix * Fix logger in chain sim * Optimize logging * Explain dry run usage * Add missing newlines after dots ~style~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConcludesFixes #2937