Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyperchains parent layer #3335

Merged
merged 11 commits into from Sep 10, 2020
Merged

Hyperchains parent layer #3335

merged 11 commits into from Sep 10, 2020

Conversation

erlmachinedev
Copy link
Contributor

@erlmachinedev erlmachinedev commented Aug 25, 2020 •
edited

This is a draft of parent chain interaction behaviour:

  1. aehc_connector.erl with send_tx/1, get_block/1, publish/1, subscribe/1 interface;
  2. aehc_chain_sim_connector.erl which mounted simulator chain;

@gorbak25
Copy link
Contributor

This PR needs to be changed according to our today's discussion.

gorbak25
gorbak25 suggested changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@gorbak25 gorbak25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly cosmetic changes are needed, some changes will need to wait until the commitment PR will be done.

apps/aehyperchains/src/connectors/aehc_chain_sim_connector.erl Outdated Show resolved Hide resolved
apps/aehyperchains/src/connectors/aehc_chain_sim_connector.erl Outdated Show resolved Hide resolved
apps/aehyperchains/src/connectors/aehc_chain_sim_connector.erl Outdated Show resolved Hide resolved
apps/aehyperchains/src/connectors/aehc_chain_sim_connector.erl Outdated Show resolved Hide resolved
apps/aehyperchains/src/connectors/aehc_chain_sim_connector.erl Outdated Show resolved Hide resolved
apps/aehyperchains/src/aehc_connector.erl Outdated Show resolved Hide resolved
apps/aehyperchains/src/aehc_connector.erl Outdated Show resolved Hide resolved
apps/aehyperchains/src/aehc_connector.erl Outdated Show resolved Hide resolved
apps/aehyperchains/src/aehc_connector.erl Outdated Show resolved Hide resolved
apps/aehyperchains/src/aehc_connector.erl Outdated Show resolved Hide resolved
radrow
radrow reviewed Aug 27, 2020
View reviewed changes
apps/aehyperchains/src/aehc_connector.erl Outdated Show resolved Hide resolved
apps/aehyperchains/src/aehc_connector.erl Outdated Show resolved Hide resolved
apps/aehyperchains/src/connectors/aehc_chain_sim_connector.erl Outdated Show resolved Hide resolved
apps/aehyperchains/src/connectors/aehc_chain_sim_connector.erl Outdated Show resolved Hide resolved
apps/aehyperchains/src/aehc_connector.erl Outdated Show resolved Hide resolved
apps/aehyperchains/src/aehc_connector.erl Outdated Show resolved Hide resolved
gorbak25
gorbak25 suggested changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@gorbak25 gorbak25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just small quirks required.

apps/aecore/src/aec_plugin.erl Outdated Show resolved Hide resolved
apps/aecore/src/aec_plugin.erl Outdated Show resolved Hide resolved
apps/aecore/src/aec_plugin.erl Outdated Show resolved Hide resolved
apps/aecore/test/aec_chain_sim.erl Outdated Show resolved Hide resolved
apps/aecore/test/aec_chain_sim.erl Show resolved Hide resolved
apps/aecore/test/aec_chain_sim.erl Show resolved Hide resolved
apps/aecore/test/aec_chain_sim.erl Outdated Show resolved Hide resolved
apps/aecore/test/aec_chain_sim.erl Show resolved Hide resolved
apps/aecore/test/aec_chain_sim.erl Show resolved Hide resolved
apps/aehyperchains/src/aehc_connector.erl Show resolved Hide resolved
@gorbak25 gorbak25 force-pushed the hyperchains-master branch 2 times, most recently from 5d10706 to 91847c3 Compare September 4, 2020 15:15
@erlmachinedev erlmachinedev self-assigned this Sep 7, 2020
gorbak25
gorbak25 approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@gorbak25 gorbak25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erlmachinedev erlmachinedev merged commit 34cdb68 into hyperchains-master Sep 10, 2020
@erlmachinedev erlmachinedev deleted the hyperchains-parent-layer branch September 10, 2020 21:35
gorbak25 pushed a commit that referenced this pull request Nov 6, 2020
@erlmachinedev @gorbak25
Hyperchains parent layer (#3335)
6ff876d 
* Parent connector behaviour; Chain simulator connector draft;

* Interface was changed accordingly to disscussion;

* Connector validation; Block subscription;

* Signing transactions;

* Add block events; Compatibility with OTP21;

* Tests for Chain Simulator connector;

* Address review comments;

* Add get_block_by_hash/1 to connector API; Move test connector to test dir;

* Add export type; Dializer fixes;

* Fix tests; Enable mocks from test utils;
gorbak25 pushed a commit that referenced this pull request Jan 26, 2021
@erlmachinedev @gorbak25
Hyperchains parent layer (#3335)
b262757 
* Parent connector behaviour; Chain simulator connector draft;

* Interface was changed accordingly to disscussion;

* Connector validation; Block subscription;

* Signing transactions;

* Add block events; Compatibility with OTP21;

* Tests for Chain Simulator connector;

* Address review comments;

* Add get_block_by_hash/1 to connector API; Move test connector to test dir;

* Add export type; Dializer fixes;

* Fix tests; Enable mocks from test utils;
gorbak25 pushed a commit that referenced this pull request Feb 9, 2021
@erlmachinedev @gorbak25
Hyperchains parent layer (#3335)
ef02256 
* Parent connector behaviour; Chain simulator connector draft;

* Interface was changed accordingly to disscussion;

* Connector validation; Block subscription;

* Signing transactions;

* Add block events; Compatibility with OTP21;

* Tests for Chain Simulator connector;

* Address review comments;

* Add get_block_by_hash/1 to connector API; Move test connector to test dir;

* Add export type; Dializer fixes;

* Fix tests; Enable mocks from test utils;
gorbak25 pushed a commit that referenced this pull request Mar 8, 2021
@erlmachinedev @gorbak25
Hyperchains parent layer (#3335)
cc3d8e0 
* Parent connector behaviour; Chain simulator connector draft;

* Interface was changed accordingly to disscussion;

* Connector validation; Block subscription;

* Signing transactions;

* Add block events; Compatibility with OTP21;

* Tests for Chain Simulator connector;

* Address review comments;

* Add get_block_by_hash/1 to connector API; Move test connector to test dir;

* Add export type; Dializer fixes;

* Fix tests; Enable mocks from test utils;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorbak25 gorbak25 gorbak25 approved these changes

@radrow radrow radrow approved these changes

Assignees

@erlmachinedev erlmachinedev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erlmachinedev @gorbak25 @radrow