new P2P info message #3423
Merged
new P2P info message #3423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding protocol PR will follow |
uwiger
reviewed
Dec 8, 2020
| NodeInfo = #{ version => NodeVersion | ||
| , os => OS | ||
| , network_id => aec_governance:get_network_id() | ||
| , verified_peers => 2 |
apps/aecore/src/aec_sync.erl
Outdated
| end) | ||
| end, | ||
| L), | ||
| pmap_gather(length(L), []). |
There was a problem hiding this comment.
One way to write such a pmap (apologies for syntax errors):
Pids = [spawn_monitor(fun() -> exit({ok, PerformTask(E)} end) || E <- L],
pmap_gather(Pids, []).
pmap_gather([], Acc) ->
Acc;
pmap_gather([{Pid, MRef}|Pids], Acc) ->
receive
{'DOWN', MRef, process, Pid, Res} ->
case Res of
{ok, GoodRes} -> pmap_gather(Pids, [GoodRes | Acc]);
Error -> do_something_clever()
end
end.This also captures crashes, and makes it possible to tell the difference.
Co-authored-by: Ulf Wiger <ulf@wiger.net>
gorbak25
reviewed
Dec 10, 2020
gorbak25
reviewed
Dec 10, 2020
gorbak25
reviewed
Dec 10, 2020
| @@ -50,6 +52,15 @@ get_generation(PeerId, Hash) -> | |||
| set_last_generation_in_sync() -> | |||
| gen_server:cast(?MODULE, set_last_generation_in_sync). | |||
|
|
|||
| ask_all_for_node_info() -> | |||
There was a problem hiding this comment.
I think it should be exposed by HTTP for internal use.
There was a problem hiding this comment.
I wouldn't make this part of the node at all, it's a reporting functionality IMO.
There was a problem hiding this comment.
I'd rather keep it as an internal API which we call on demand. My concern would be an abuse of this API.
gorbak25
suggested changes
Dec 10, 2020
gorbak25
reviewed
Dec 15, 2020
gorbak25
previously approved these changes
Dec 15, 2020
gorbak25
approved these changes
Dec 16, 2020
uwiger
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3107
The work on this PR had been supported by the Aeternity Foundation.