Make inner tx of PayingForTx non-valid #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanssv
reviewed
Jan 4, 2021
uwiger
approved these changes
Jan 4, 2021
gorbak25
suggested changes
Jan 4, 2021
There was a problem hiding this comment.
Please forbid using "-inner_tx" in the network id.
If at some point someone launches "ae_mainnet-inner_tx" then inner transactions from ae_mainnet could be published on "ae_mainnet-inner_tx". When starting/booting the node please hard crash when the network id ends with "-inner_tx" so someone in the future doesn't accidentally shot himself in the foot.
|
I wonder if it isn't better to make a quiz with random detailed questions about AE that you have to answer correctly in order to be allowed to start the node? I don't think we will be able to stop truly people from shooting themselves in the foot otherwise? |
hanssv
approved these changes
Jan 4, 2021
gorbak25
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3054
There is a suggested approach in the issue: use empty
network_idfor signing the inner transaction. This has one big flaw: the inner transaction is repayable on a different network with a differentnetwork_id. Instead I took a slightly different approach: the inner transaction uses<netwok_id>-<encoded payer_id>, so for example it would be usedae_mainnet-ak_123.... Note that the payer account's ID is Base58c encoded.The work on this PR is supported by the Aeternity Crypto Foundation.