Update README.md #3762
Merged
Update README.md #3762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a few more information to get people going more easily.
dincho
previously approved these changes
Nov 1, 2021
hanssv
previously approved these changes
Nov 1, 2021
uwiger
previously approved these changes
Nov 1, 2021
velzevur
requested changes
Nov 2, 2021
README.md
Outdated
|
|
||
|
|
||
|
|
||
| **Linux / Mac / Win** |
There was a problem hiding this comment.
The suggested command will not work on Windows as the slashes are all wrong.
Also the following line starts with "Or running a docker container" and does not read well in the context of a new header.
There was a problem hiding this comment.
oof good catch @velzevur , let me find someone to test on windows...
add proper docker setup CMDs for windows
nikita-fuchs
dismissed stale reviews from uwiger, hanssv, and dincho
via
34b0b39
fix formatting mistakes
add $s for better readability/clarification
uwiger
previously approved these changes
Nov 4, 2021
dincho
requested changes
Nov 4, 2021
README.md
Outdated
| mkdir -p ~/.aeternity/maindb | ||
| docker pull aeternity/aeternity | ||
| docker run -p 3013:3013 -p 3015:3015 \ | ||
| $ mkdir -p ~/.aeternity/maindb |
There was a problem hiding this comment.
that prevents copy pasting the whole block
dincho
reviewed
Nov 4, 2021
README.md
Outdated
| ```bash | ||
| $ mkdir %APPDATA%\aeternity\maindb | ||
| $ docker pull aeternity/aeternity | ||
| $ docker run -p 3013:3013 -p 3015:3015 -v %APPDATA%/aeternity/maindb:/home/aeternity/node/data/mnesia aeternity/aeternity |
There was a problem hiding this comment.
please make it multi-line to be consistent with the above command
There was a problem hiding this comment.
no, because in command prompt and powershell the newline escape sign is inconsistent, we'll keep it simple.
remove command indicators for easier command block copying.
dincho
approved these changes
Nov 17, 2021
uwiger
approved these changes
Nov 18, 2021
velzevur
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a few more information to get people going more easily.